Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build image to use go 1.20 #45

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Update build image to use go 1.20 #45

merged 2 commits into from
Mar 8, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Mar 7, 2023

No description provided.

@rfratto rfratto requested a review from tpaschalis March 7, 2023 20:51
@rfratto
Copy link
Member Author

rfratto commented Mar 7, 2023

The linter is still failing, which tells me it's unrelated to the PR, since I didn't touch anything here to change it. For now I'm choosing to ignore the lint errors; After this PR I'll bump the GitHub actions and the used build image to get everything on newer versions of things which should get it working again.

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpaschalis
Copy link
Member

Similar CI failure due to the linter in other repo. I think it might pass when the new linter version is merged.

@rfratto rfratto merged commit 744b2cc into master Mar 8, 2023
@rfratto rfratto deleted the update-build-image branch March 8, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants