Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Drone CI configuration #9

Merged
merged 15 commits into from
Aug 6, 2020
Merged

Add initial Drone CI configuration #9

merged 15 commits into from
Aug 6, 2020

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Aug 3, 2020

  • test and build on all events and references
  • release on tag events

Currently this uses our internal Drone server but that can be changed to the public drone server once the repository is made public.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry changed the title Add initial CI configuration Add initial Drone CI configuration Aug 3, 2020
@jdbaldry
Copy link
Member Author

jdbaldry commented Aug 3, 2020

I didn't actually see that this repo already had GitHub actions for doing the test, lint, and build steps. Clearly, I need to implement cross compilation for this PR to replace those existing workflows. The release pipeline should still be valuable in the mean time but I imagine we will want the cross build testing in Drone before this is merged.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@simonswine
Copy link
Collaborator

This looks very good already, many thanks. Will have a closer look tomorrow.

I need to implement cross compilation

Do not worry about this, I doubt we need anything apart from Linux amd64. I just copied it from somewhere else 🙂

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
Copy link
Member Author

jdbaldry commented Aug 4, 2020

Whoops, I didn't see your comment come through before I implemented cross compilation!

Even though cross compilation isn't strictly necessary, it was likely we were going to need to create and maintain a build-image for CI purposes anyway so it wasn't wasted effort.

If you want to inspect the drone pipelines you can go to http://drone.grafana.net/grafana/prometheus-pulsar-remote-write/ and you can also look at the release vtest2 for the result of the release pipeline. Once we are happy with this, I can make sure that we have a Docker Hub image under the grafana org instead of my own account and I'll clean up the test release tags.

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks (almost) prefect. Thank you for your work on that 👍

I think the next steps (as far as I would see them):

  • Build and push a docker image for linux-amd64
  • Move to a docker.io/grafana repo
  • Disable Github actions

.drone/drone.yml Show resolved Hide resolved
.drone/drone.yml Outdated Show resolved Hide resolved
build-image/Dockerfile Outdated Show resolved Hide resolved
build-image/Dockerfile Outdated Show resolved Hide resolved
build-image/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
Copy link
Member Author

jdbaldry commented Aug 6, 2020

@simonswine I think I've now addressed all comments so this should be good to go now :)

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for this 🎉

Feel free to push the button @jdbaldry

@jdbaldry jdbaldry merged commit 0c2ae46 into master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants