-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Drone CI configuration #9
Conversation
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
I didn't actually see that this repo already had GitHub actions for doing the test, lint, and build steps. Clearly, I need to implement cross compilation for this PR to replace those existing workflows. The |
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
This looks very good already, many thanks. Will have a closer look tomorrow.
Do not worry about this, I doubt we need anything apart from Linux amd64. I just copied it from somewhere else 🙂 |
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Whoops, I didn't see your comment come through before I implemented cross compilation! Even though cross compilation isn't strictly necessary, it was likely we were going to need to create and maintain a build-image for CI purposes anyway so it wasn't wasted effort. If you want to inspect the drone pipelines you can go to http://drone.grafana.net/grafana/prometheus-pulsar-remote-write/ and you can also look at the release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks (almost) prefect. Thank you for your work on that 👍
I think the next steps (as far as I would see them):
- Build and push a docker image for linux-amd64
- Move to a docker.io/grafana repo
- Disable Github actions
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@simonswine I think I've now addressed all comments so this should be good to go now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks for this 🎉
Feel free to push the button @jdbaldry
Currently this uses our internal Drone server but that can be changed to the public drone server once the repository is made public.