Propagate metric metadata via remote write #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to the WAL watcher, its purpose is to observe the scrape manager and pull metadata. Then, send it to a remote storage. Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
changed the title
cstyan
approved these changes
Mar 27, 2020
rfratto
approved these changes
Mar 27, 2020
rfratto
reviewed
Mar 31, 2020
There was a problem hiding this comment.
awesome job @gotjosh!
I gave the code here a quick scan looking for idiomatic code and didn't try validating correctness to the design doc, since presumably Prometheus maintainers with way more context than me took a close look at everything here. I only found one nit (and one extra silly nit), but you did great work getting this to the state it's in today 👏
gotjosh
pushed a commit
that referenced
this pull request
May 15, 2020
npazosmendez
added a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a stab at that by using a similar approach to the WAL watcher. We observe the
scrapeCachebased on a specified period and pull the available metadata to send it to remote storage.A high-level diagram of the process looks like:
Documentation that explains the thinking behind this design lives in this design doc. The first version of the design doc contained details about other parts not relevant to Prometheus. Highly advise to only analyse the former.
Signed-off-by: gotjosh josue@grafana.com