Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feat-remote-write-metadata to 2.21.0 #12

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

gotjosh
Copy link

@gotjosh gotjosh commented Oct 21, 2020

Similarly to the WAL watcher, its purpose is to observe the scrape manager and pull metadata. Then, send it to a remote storage.

Signed-off-by: gotjosh josue@grafana.com

Similarly to the WAL watcher, its purpose is to observe the scrape manager and pull metadata. Then, send it to a remote storage.

Signed-off-by: gotjosh <josue@grafana.com>
@gotjosh gotjosh requested a review from rfratto October 21, 2020 19:58
@gotjosh
Copy link
Author

gotjosh commented Oct 21, 2020

I had two conflicts, one in config due to a new comment and one in queue_manager due to an error that was made public (RecoveableError).

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sounds like the conflicts you ran into don't warrant a really close look (but I did give it a skim)

@gotjosh gotjosh merged commit cf00050 into release-2.21.0-grafana Oct 21, 2020
@rfratto rfratto deleted the feat-remote-write-metadata-2.21 branch October 4, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants