Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feat-shared-interner to 2.26.0 #18

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 6, 2021

No description provided.

This commit exposes the string interner globally with a shared pool and
modifies both the scraper and remote_write to use that shared pool.

Note that the string_interner_zero_reference_releases_total now has a
different namespace and subsystem from what it was initially set to in
the RW code.

Signed-off-by: Robert Fratto <robert.fratto@grafana.com>
@rfratto
Copy link
Member Author

rfratto commented Apr 6, 2021

The code owners will need to be changed, this is the release branch used for the Agent 🤔 Everything works though and conflicts were minimal, going to merge.

@rfratto rfratto merged commit 88f5747 into release-2.26.0-grafana Apr 6, 2021
@rfratto rfratto deleted the feat-shared-interner branch April 6, 2021 13:09
@rfratto rfratto restored the feat-shared-interner branch April 6, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant