Fix: Set the scrape manager #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Unfortunately making sure something is initialized is generally out of scope of Go tooling, even linters. While languages like Rust force everything to have a default value, Go's convention of the zero value being useful leads to situations like this that can't be covered by lint rules and are easy to miss.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely missed this in my original PR. I believe I lost it on my last rebase from master to FF my original branch.
I'm a bit surprised that
gofmtdidn't yell at something like this. As for a test, I couldn't come up with a good test to ensure this does not happen again other than setting it and then ensure it is there - but that seems unnecessary? Opinions are welcome.