Temporarily symlink pkg and util/modtimevfs #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit exposes the string interner globally with a shared pool and modifies both the scraper and remote_write to use that shared pool. Note that the string_interner_zero_reference_releases_total now has a different namespace and subsystem from what it was initially set to in the RW code. Signed-off-by: Robert Fratto <robert.fratto@grafana.com>
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
Grafana Agent dependencies (i.e., Promtail) are using old paths for some Prometheus packages. Updating them would be a challenge and require immediately switching over to grafana/dskit, which is a non-trivial upgrade. This commit temporarily works around the solution by symlinking the old path names so existing agent dependencies that use older versions of Prometheus can continue to work without needing to be upgraded immediately. Signed-off-by: Robert Fratto <robertfratto@gmail.com>
rfratto
requested review from
csmarchbanks,
cstyan and
tomwilkie
as code owners
|
Closing. I tested this locally and it's not enough to symlink the packages; the APIs also changed in general so the other dependencies still fail to build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana Agent dependencies (i.e., Promtail) are using old paths for some Prometheus packages. Updating them would be a challenge and require immediately switching over to grafana/dskit, which is a non-trivial upgrade.
This commit temporarily works around the solution by symlinking the old path names so existing agent dependencies that use older versions of Prometheus can continue to work without needing to be upgraded immediately.