Cherry-pick sharding-up improvements from prometheus 2.33.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drive the input parameters to `calculateDesiredShards()` very precisely, to illustrate some questionable behaviour marked with `?!`. See prometheus#9178, prometheus#9207, Signed-off-by: Bryan Boreham <bjboreham@gmail.com> (cherry picked from commit d588b14)
Change the coefficient from 1% to 5%, so instead of targetting to clear the backlog in 100s we target 20s. Update unit test to reflect the new behaviour. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> (cherry picked from commit 6d01ce8)
Previously we would reject an increase from 2 to 2.5 as being within 30%; by rounding up first we see this as an increase from 2 to 3. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> (cherry picked from commit 954c0e8)
iainlane
requested review from
csmarchbanks,
cstyan and
tomwilkie
as code owners
5 tasks
iainlane
requested review from
bboreham and
rfratto
and removed request for
tomwilkie,
cstyan and
csmarchbanks
bboreham
reviewed
Feb 18, 2022
|
|
||
| metrics := newQueueManagerMetrics(nil, "", "") | ||
| samplesIn := newEWMARate(ewmaWeight, shardUpdateDuration) | ||
| m := NewQueueManager(metrics, nil, nil, nil, dir, samplesIn, cfg, mcfg, nil, nil, c, defaultFlushDeadline, newPool(), newHighestTimestampMetric(), nil, false) |
There was a problem hiding this comment.
Looks like this has to be intern.New(nil) until prometheus#10231 merges.
|
Quick update, @rfratto indicated that the current focus is to be able to vendor prometheus mainline again, the version which already contains this fix. So I'll pause working on this PR for a bit, & hopefully it can be closed as obsolete. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch cherry-picks http://github.com/prometheus/prometheus/pull/9274 which are some improvements to the behaviour when sharding up with a backlog.
Part of: grafana/agent#1376