Merge feat-remote-write-metadata to v2.17.1-grafana #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to the WAL watcher, its purpose is to observe the scrape manager and pull metadata. Then, send it to a remote storage. Signed-off-by: gotjosh <josue@grafana.com>
|
Gonna take a moment to apply your feedback (and anything that might come up out of the current issue in ops-tools). Give me a couple of hours before emerging this one. |
Signed-off-by: gotjosh <josue@grafana.com>
|
I'm not sure how you managed to spot that extra space, great find. |
gotjosh
approved these changes
Apr 3, 2020
|
I'm going to rename the release branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly unchanged from the
shared-internerbranch but I rebased my code out of it so it's just the remote_write metadata propagation code now.