rebase feat-remote-write-metadata on release-2.20.1-grafana #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
force-pushed
the
feat-remote-write-metadata
branch
from
16a9c27
to
c08b0b7
Compare
rfratto
approved these changes
Aug 20, 2020
Similarly to the WAL watcher, its purpose is to observe the scrape manager and pull metadata. Then, send it to a remote storage. Signed-off-by: gotjosh <josue@grafana.com>
gotjosh
force-pushed
the
feat-remote-write-metadata
branch
from
49972ef
to
19dbf15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a fair share of conflicts around
QueueManagerand its test so I'd appreciate a second look around that.Remote write tests pass and Prometheus builds but I'd feel a bit more confident if we can run this in dev with metadata enabled for a bit to ensure everything is a-OK.