Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100 update builtin pipeline #105

Merged
merged 4 commits into from
Nov 3, 2023
Merged

100 update builtin pipeline #105

merged 4 commits into from
Nov 3, 2023

Conversation

jamesc-grafana
Copy link
Collaborator

Updates to the Okta pipeline to match the pipeline that @kelnage created in YAML

@jamesc-grafana jamesc-grafana added the pipeline Related to changes to the pipelines label Nov 2, 2023
@jamesc-grafana jamesc-grafana self-assigned this Nov 2, 2023
@jamesc-grafana jamesc-grafana requested a review from a team as a code owner November 2, 2023 17:22
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

mostafa
mostafa approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

I'd wait for @kelnage's opinion as well, as he knows more about Okta log schema.

@mostafa mostafa requested a review from kelnage November 3, 2023 09:55
kelnage
kelnage approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@kelnage kelnage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the unit test, great work!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited

Pull Request Test Coverage Report for Build 6745548861

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.149%
Totals Coverage Status
Change from base Build 6745532340: 0.0%
Covered Lines: 466
Relevant Lines: 470
💛 - Coveralls

@jamesc-grafana jamesc-grafana merged commit 38c81e4 into main Nov 3, 2023
8 of 9 checks passed
@jamesc-grafana jamesc-grafana deleted the 100-update-builtin-pipeline branch November 3, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafa mostafa mostafa approved these changes

@kelnage kelnage kelnage approved these changes

Assignees

@jamesc-grafana jamesc-grafana

Labels
pipeline Related to changes to the pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamesc-grafana @CLAassistant @mostafa @kelnage