chore: Update pySigma to v0.11.3 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only includes for the tests/sigma_backend_tester.py which is no longer our preferred method of testing the backend.
apply can be applied to either SigmaRule or SigmaCorrelationRule
Trying to prevent chicken and egg arguments.
Pull Request Test Coverage Report for Build 7829167770
馃挍 - Coveralls |
mostafa
approved these changes
Feb 8, 2024
The integration test results should not be impacted by the versions of ubuntu, python or poetry used, so we can use the latest for each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pySigma-backend-loki to use the latest (v.0.11.3) version of pySigma. Unfortunately we have a slight chicken-and-egg issue here, in that it's failing the CI because of the integration check (I need to update pySigma-plugin-directory to reflect the new version - which is true - once we actually do our release) - but that is causing all our tests to fail and thus preventing the PR from being merged 馃う
Hence I have removed the integration test from the main test workflow and created a new integration workflow for testing this instead. That workflow is configured as a soft-fail that doesn't prevent PRs, but does encourage us to check it (especially prior to a release). I decided to test the integration workflow on all the supported versions of Python - but arguably that shouldn't be necessary (I think) - testing it on just the latest version we support might be more than acceptable?
I also removed our dependency on the sysmon pipeline as this was preventing me from updating to pySigma v.0.11.3 (the pipeline still only support v0.10) and was only being used in our prior testing scripts.
Fixes #126.