Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flake8 and black with ruff #132

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Replace flake8 and black with ruff #132

merged 4 commits into from
Mar 12, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Feb 28, 2024 •
edited

This PR removes flake8 and black and replaces them with ruff. Ruff supports more linters out of the box.

Closes #129
Closes #133

@coveralls
Copy link

coveralls commented Feb 28, 2024 •
edited

Pull Request Test Coverage Report for Build 8246990426

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.151%
Totals Coverage Status
Change from base Build 8081702774: 0.0%
Covered Lines: 467
Relevant Lines: 471
💛 - Coveralls

@mostafa mostafa changed the title Add ruff Replace flake8 and black with ruff Feb 28, 2024
@mostafa mostafa marked this pull request as ready for review February 28, 2024 16:44
@mostafa mostafa requested a review from a team as a code owner February 28, 2024 16:44
@mostafa mostafa requested a review from kelnage February 29, 2024 12:19
kelnage
kelnage approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@kelnage kelnage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mostafa mostafa merged commit 4c4fe2b into main Mar 12, 2024
13 checks passed
@mostafa mostafa deleted the add-ruff branch March 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelnage kelnage kelnage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mostafa @coveralls @kelnage