Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure author name is included in alert #59

Merged
merged 2 commits into from
May 25, 2023
Merged

Ensure author name is included in alert #59

merged 2 commits into from
May 25, 2023

Conversation

kelnage
Copy link
Collaborator

@kelnage kelnage commented May 25, 2023

When converting a rule into an alert, include the author of the rule in the alert configuration by default.

When converting a rule into an alert, include the author of the rule in
the alert configuration by default.
@kelnage kelnage requested a review from a team as a code owner May 25, 2023 11:14
@github-actions
Copy link

github-actions bot commented May 25, 2023

Pull Request Test Coverage Report for Build 5079340485

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.774%

Totals Coverage Status
Change from base Build 5056382345: 0.001%
Covered Lines: 441
Relevant Lines: 442

💛 - Coveralls

Copy link
Contributor

@romain-gaillard romain-gaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kelnage kelnage merged commit c5f4b4c into main May 25, 2023
9 checks passed
@kelnage kelnage deleted the alert-rule-author branch May 25, 2023 11:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5079340485

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.774%

Totals Coverage Status
Change from base Build 5056382345: 0.001%
Covered Lines: 441
Relevant Lines: 442

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants