Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest versions #63

Merged
merged 3 commits into from
May 31, 2023
Merged

Update dependencies to latest versions #63

merged 3 commits into from
May 31, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented May 29, 2023

Closes #60.
Closes #61.
Closes #62.

@mostafa mostafa requested a review from a team as a code owner May 29, 2023 13:25
@github-actions
Copy link

github-actions bot commented May 29, 2023

Pull Request Test Coverage Report for Build 5123455618

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.774%

Totals Coverage Status
Change from base Build 5079377213: 0.0%
Covered Lines: 441
Relevant Lines: 442

💛 - Coveralls

Copy link
Collaborator

@kelnage kelnage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this updates pySigma to 0.9.11 and I'm trying to avoid doing that until we support the new cased modifier (questionable whether upstream should have made it a minor rather than a patch update, honestly). If that can be held back for the time being, it would be preferable.

@mostafa mostafa requested a review from kelnage May 30, 2023 13:57
poetry.lock Outdated
@@ -500,14 +487,13 @@ diagrams = ["jinja2", "railroad-diagrams"]

[[package]]
name = "pysigma"
version = "0.9.9"
version = "0.9.11"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new lock file is still updating pySigma to 0.9.11. If we lock pySigma to 0.9.9 for the time being in the pyproject.toml, it should avoid this issue.

@mostafa mostafa requested a review from kelnage May 30, 2023 15:34
Copy link
Collaborator

@kelnage kelnage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mostafa mostafa merged commit 6496979 into main May 31, 2023
9 checks passed
@mostafa mostafa deleted the update-dependencies branch May 31, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants