cased Sigma modifier
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test support for the new "|cased" modifier for pySigma, and update packages to enable it.
Checking for the new SigmaCasedString and treating appropriately. Note, this class is a subclass of SigmaString, so isinstance(x, SigmaString) will also return true for it.
When the backend is in case sensitive mode, the cased modifier should make no difference to its output. Also, the startswith/endswith/contains modifiers interact with the cased keyword and also needed testing.
The code added to the pySigma library to handle the cased modifier meant our overrides were skipped. This fixes the issue by enforcing the call to convert the str into a regex if the value contains one or more wildcards.
…ased-sensitive-modifier
Pull Request Test Coverage Report for Build 5242466898
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the
casedmodifier to ensure it generates accurate LogQL queries.Given the default behavior for LogQL is case-sensitive, this is somewhat simple - but it did require some effort to correctly support in edge cases where pySigma was trying to introduce wildcards.