Fixing backend options parsing for sigma-cli
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigma-cli provides all backend options as strings, rather than the types specified in the backend __init__ function. This changes the code to reflect that possibility and adds simple coercion for string values into booleans.
Also update another dependency
romain-gaillard
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the primary methods for using
pySigma-backend-lokiis viasigma-cli. This supports backend options, but passes through the arguments as string values, not the types specified in the backend itself. This meant that to setcase_insensitivetoFalse, a user must provide the empty string (as that is the only Python string value that evaluates asFalse) and if-O add_line_filters=falsewas provided as an argument tosigma-cli, it would still attempt to add line filters, neither of which would likely be the expected or desired behaviour.This PR fixes the issue, introducing a simple coercion for those string values (case-insensitive comparison for each boolean value to
true), and adds a corresponding unit test.