Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigma CLI integration testing #85

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Sigma CLI integration testing #85

merged 4 commits into from
Sep 5, 2023

Conversation

kelnage
Copy link
Collaborator

@kelnage kelnage commented Sep 5, 2023

Improve the release process by updating documentation and introduce a workflow to test whether the backend a) is compatible with, b) can be installed correctly from, and c) can be used to convert a simple example Sigma rule by the latest version of sigma-cli.

@kelnage kelnage added the enhancement New feature or request label Sep 5, 2023
@kelnage kelnage requested a review from mostafa September 5, 2023 08:34
@kelnage kelnage self-assigned this Sep 5, 2023
@kelnage kelnage requested a review from a team as a code owner September 5, 2023 08:34
@romain-gaillard
Copy link
Contributor

It looks very good to me, that's a nice script!
I'll let @mostafa approve the PR as he's in the best position to provide better feedback than I am 😄

set -e and grep are such a pain together!
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Pull Request Test Coverage Report for Build 6082434977

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.784%

Totals Coverage Status
Change from base Build 6050743976: 0.0%
Covered Lines: 462
Relevant Lines: 463

💛 - Coveralls

@kelnage kelnage merged commit 08a5498 into main Sep 5, 2023
9 checks passed
@kelnage kelnage deleted the release-improvements branch September 5, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants