Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple conditions shared state #98

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

kelnage
Copy link
Collaborator

@kelnage kelnage commented Oct 19, 2023

Applies fixes from SigmaHQ/pySigma#127 to resolve the issue that a list of conditions in a single rule would all share the same state.

Closes #72

Applies fixes from SigmaHQ/pySigma#127 to fix the issue that a list of
conditions would all share the same state.
@kelnage kelnage added the bug Something isn't working label Oct 19, 2023
@kelnage kelnage self-assigned this Oct 19, 2023
@kelnage kelnage requested a review from a team as a code owner October 19, 2023 15:10
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Pull Request Test Coverage Report for Build 6576647696

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.784%

Totals Coverage Status
Change from base Build 6558145661: 0.0%
Covered Lines: 461
Relevant Lines: 462

💛 - Coveralls

Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kelnage kelnage merged commit 616ef64 into main Oct 20, 2023
9 checks passed
@kelnage kelnage deleted the fix-multiple-conditions-state branch October 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki does not handle condition lists in the manner other backends do
2 participants