Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flag disable agent #123

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

zalintyre
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2023

CLA assistant check
All committers have signed the CLA.

@zalintyre
Copy link
Contributor Author

Documentation added in grafana/pyroscope#2536

@zalintyre zalintyre marked this pull request as ready for review October 15, 2023 00:52
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zalintyre for this contribution.

Tested this locally e2e and works as expected. LGTM

@simonswine simonswine merged commit 3113bf6 into grafana:main Oct 18, 2023
13 checks passed
@zalintyre zalintyre deleted the feature/flag-disable-agent branch October 18, 2023 18:25
@zalintyre
Copy link
Contributor Author

zalintyre commented Oct 18, 2023

Hi @simonswine,

thank you for merging this PR! It would be nice if you added the hacktoberfest-accepted label to this PR, or even the hacktoberfest label to the repository.

@simonswine simonswine added the hacktoberfest-accepted This contribution is part of https://hacktoberfest.com/ label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This contribution is part of https://hacktoberfest.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants