Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow timeout to be configurable #16

Merged
merged 1 commit into from Oct 4, 2022
Merged

feat: allow timeout to be configurable #16

merged 1 commit into from Oct 4, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 4, 2022

Closes #15

@eh-am eh-am marked this pull request as ready for review October 4, 2022 17:22
@petethepig petethepig self-requested a review October 4, 2022 17:29
@korniltsev
Copy link
Collaborator

not related to the pr but we also wanted to configure
http.Transport{
MaxConnsPerHost: <<
},

@eh-am eh-am merged commit 8f80d90 into main Oct 4, 2022
@eh-am eh-am deleted the feat/configurable-timeout branch October 4, 2022 18:00
@pyroscopebot pyroscopebot mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

@petethepig petethepig Awaiting requested review from petethepig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make http timeout to be configurable
2 participants
@eh-am @korniltsev