Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.tag_wrapper and other methods cause errors if pyroscope not configured #70

Closed
davidhao3300 opened this issue Dec 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@davidhao3300
Copy link

Describe the bug you encountered:

Repro:

import pyroscope

with pyroscope.tag_wrapper({"key": "value"}):
    print("hello world")
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })', src/lib.rs:173:64
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
Aborted (core dumped)

What did you expect to happen instead?

Not have the program crash if pyroscope is not configured, right now I have to add a wrapper on top to no-op the tag_wrapper if pyroscope is not configured.

How did you install pyroscope-rs?

pip

@davidhao3300 davidhao3300 added the bug Something isn't working label Dec 22, 2022
@korniltsev
Copy link
Collaborator

fixed here cd3c7d9

@davidhao3300
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants