Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PYROSCOPE_ADHOC_SERVER_ADDRESS #88

Open
eh-am opened this issue Feb 23, 2023 · 0 comments
Open

Support PYROSCOPE_ADHOC_SERVER_ADDRESS #88

eh-am opened this issue Feb 23, 2023 · 0 comments

Comments

@eh-am
Copy link

eh-am commented Feb 23, 2023 •
edited

Similarly to what the go and nodejs agent do:

https://github.com/pyroscope-io/client/blob/a64d920d2fbab508ede3ec06cdfa68b51177088e/pyroscope/api.go#L44-L48

https://github.com/pyroscope-io/pyroscope-nodejs/blob/09d3f4d1b77d8640181e871db0fa3d60919e4a7d/src/index.ts#L44
@eh-am eh-am mentioned this issue Feb 23, 2023
Merged
eh-am added a commit to pyroscope-io/ci that referenced this issue Feb 24, 2023
@eh-am
docs: add ruby (rspec) example (#35)
6ff1f7e 
Adds a ruby example using rspec.

It manually sets `server_address` based on
`PYROSCOPE_ADHOC_SERVER_ADDRESS` since the agent doesn't support it
(grafana/pyroscope-rs#88)

Also it relies on requiring `spec_helper`, which seems to be a common
approach (
https://github.com/search?q=require+%27spec_helper%27&type=code)

Flamegraph for reference:
https://flamegraph.com/share/66cdb214-b38c-11ed-b290-023a7a0d8f77
<img
src="https://flamegraph.com/api/preview/66cdb214-b38c-11ed-b290-023a7a0d8f77?size=full"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eh-am