Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add ui tests for CLI (#95)" #106

Merged
merged 1 commit into from
May 19, 2023
Merged

Revert "Add ui tests for CLI (#95)" #106

merged 1 commit into from
May 19, 2023

Conversation

korniltsev
Copy link
Collaborator

This reverts commit 669304a.

Rperry2174
Rperry2174 approved these changes May 19, 2023
View reviewed changes
Copy link

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@korniltsev korniltsev merged commit e8b50b2 into main May 19, 2023
131 checks passed
@hi-rustin
Copy link
Contributor

Can I ask does this change broken anything? Why do we need to revert it?

@hi-rustin
Copy link
Contributor

If you want to update the snapshot, you can run the tests with TRYCMD=overwrite.

You can find the tips in the CI log.

Testing tests/cli-ui/pyroscope_cli_help_cmd_stdout.toml ... ok
Testing tests/cli-ui/pyroscope_cli_help_flag_stdout.toml ... ok
Update snapshots with `TRYCMD=overwrite`
Debug output with `TRYCMD=dump`

The CI failed because the UI changed, the change introduced by 64a23e0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rperry2174 Rperry2174 Rperry2174 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@korniltsev @hi-rustin @Rperry2174