Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof_rs: expose frame-pointer feature #124

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

alindima
Copy link
Contributor

Pyroscope is currently unusable with pprof-rs with the default stack unwinder: tikv/pprof-rs#219

Frame-pointer seems to work, so let's expose it to end users

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 4864b75 into grafana:main Jul 31, 2023
5 of 10 checks passed
@alindima
Copy link
Contributor Author

alindima commented Aug 3, 2023

Could we get a release with the latest master code? there are some useful fixes

@korniltsev korniltsev mentioned this pull request Aug 4, 2023
@korniltsev
Copy link
Collaborator

pushed pyroscope and pprofrs to crates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants