Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): exec command args #130

Merged
merged 19 commits into from
Aug 7, 2023
Merged

fix(cli): exec command args #130

merged 19 commits into from
Aug 7, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Aug 4, 2023 •
edited

there was a bug when all the args are contactenated on " " and passed as a single string argument to a child

This pr

  • fixes the bug with arguments
  • make pyroscope-cli wait for child exit then stop profiler then exit
  • update rust toolchain to 1.64 for pyroscope-cli
  • make default log-level 'error'

@korniltsev korniltsev merged commit ad88f50 into main Aug 7, 2023
44 checks passed
@korniltsev korniltsev deleted the fix/exec_args branch August 7, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@korniltsev