Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid pulling in clap crate by the library #140

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Avoid pulling in clap crate by the library #140

merged 1 commit into from
Jan 10, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Dec 21, 2023

names has made questionable decision to depend on clap by the default which brings unnecessary dependencies for the library users: https://github.com/fnichol/names/blob/b5023b03e2339bf6e860bdcef20557ab81f3ec55/Cargo.toml#L21

@mati865
Avoid pulling in clap crate by the library
7943a67 
`names` has made questionable decision to depend on `clap` by the
default which brings unnecessary dependencies for the library users:
https://github.com/fnichol/names/blob/b5023b03e2339bf6e860bdcef20557ab81f3ec55/Cargo.toml#L21
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

korniltsev
korniltsev approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@korniltsev
Copy link
Collaborator

CI was broken before. Im merging as is

@korniltsev korniltsev merged commit d118174 into grafana:main Jan 10, 2024
5 of 10 checks passed
@mati865 mati865 deleted the avoid-pulling-in-clap branch January 10, 2024 07:17
@mati865
Copy link
Contributor Author

mati865 commented Jan 10, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mati865 @CLAassistant @korniltsev