Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crashed rust example on M1 MacOS #90

Merged
merged 2 commits into from
May 12, 2023

Conversation

hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Mar 16, 2023

Try to test async example on my MacBook Pro. When I try to get the profile, it crashed. I think this is an issue from pprof-rs.

So I just fix it by using Platform specific dependencies

See more at: tikv/pprof-rs#131

Before fix:

     Running `target/debug/examples/multi-thread-report`
Start Time: 1679209309
[1]    13989 trace trap  cargo run --example multi-thread-report

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit: it would be nice if we had a test that could catch this problem and verify the fix. That is not a request though, we can merge as is

@korniltsev
Copy link
Collaborator

We will need you ti sign CLA before we merge it. We will add CLA assistant to this repo soon.

@CLAassistant
Copy link

CLAassistant commented May 11, 2023

CLA assistant check
All committers have signed the CLA.

@hi-rustin hi-rustin requested a review from korniltsev May 12, 2023 00:51
@korniltsev korniltsev merged commit d561cfa into grafana:main May 12, 2023
106 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants