fix types

grafana · Apr 10, 2024 · 38b9edc · 38b9edc
1 parent e3036ea
commit 38b9edc
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/pkg/phlaredb/delta.go b/pkg/phlaredb/delta.go
@@ -39,7 +39,7 @@ func newSampleDict(samples schemav1.Samples) map[uint32]uint64 {
 	return dict
 }
 
-func (d *deltaProfiles) computeDelta(ps schemav1.InMemoryProfile) schemav1.Samples {
+func (d *deltaProfiles) computeDelta(ps *schemav1.InMemoryProfile) schemav1.Samples {
 	d.mtx.Lock()
 	defer d.mtx.Unlock()
 

diff --git a/pkg/phlaredb/downsample/downsample_test.go b/pkg/phlaredb/downsample/downsample_test.go
@@ -106,7 +106,7 @@ func TestDownsampler_Aggregation(t *testing.T) {
 }
 
 func TestDownsampler_VaryingFingerprints(t *testing.T) {
-	profiles := make([]schemav1.InMemoryProfile, 0)
+	profiles := make([]*schemav1.InMemoryProfile, 0)
 	for i := 0; i < 5; i++ {
 		builder := testhelper.NewProfileBuilder(1703853310000000000).CPUProfile() // 2023-12-29T12:35:10Z
 		builder.ForStacktraceString("a", "b", "c").AddSamples(30)

diff --git a/pkg/phlaredb/head.go b/pkg/phlaredb/head.go
@@ -217,7 +217,7 @@ func (h *Head) Ingest(ctx context.Context, p *profilev1.Profile, id uuid.UUID, e
 			continue
 		}
 
-		if err := h.profiles.ingest(ctx, []schemav1.InMemoryProfile{profile}, lbls[idxType], metricName); err != nil {
+		if err := h.profiles.ingest(ctx, []*schemav1.InMemoryProfile{profile}, lbls[idxType], metricName); err != nil {
 			return err
 		}
 

diff --git a/pkg/phlaredb/profile_store.go b/pkg/phlaredb/profile_store.go
@@ -385,7 +385,7 @@ func (s *profileStore) writeRowGroups(path string, rowGroups []parquet.RowGroup)
 	return n, numRowGroups, nil
 }
 
-func (s *profileStore) ingest(_ context.Context, profiles []schemav1.InMemoryProfile, lbs phlaremodel.Labels, profileName string) error {
+func (s *profileStore) ingest(_ context.Context, profiles []*schemav1.InMemoryProfile, lbs phlaremodel.Labels, profileName string) error {
 	s.profilesLock.Lock()
 	defer s.profilesLock.Unlock()
 
@@ -400,15 +400,15 @@ func (s *profileStore) ingest(_ context.Context, profiles []schemav1.InMemoryPro
 		}
 
 		// add profile to the index
-		s.index.Add(&p, lbs, profileName)
+		s.index.Add(p, lbs, profileName)
 
 		// increase size of stored data
 		addedBytes := profiles[pos].Size()
 		s.metrics.sizeBytes.WithLabelValues(s.Name()).Set(float64(s.size.Add(addedBytes)))
 		s.totalSize.Add(addedBytes)
 
 		// add to slice
-		s.slice = append(s.slice, &p)
+		s.slice = append(s.slice, p)
 		s.metrics.samples.Add(float64(len(p.Samples.StacktraceIDs)))
 
 	}

diff --git a/pkg/phlaredb/profile_store_test.go b/pkg/phlaredb/profile_store_test.go
@@ -236,7 +236,7 @@ func TestProfileStore_RowGroupSplitting(t *testing.T) {
 
 			for i := 0; i < 100; i++ {
 				p := tc.values(i)
-				require.NoError(t, store.ingest(ctx, []schemav1.InMemoryProfile{p.p}, p.lbls, p.profileName))
+				require.NoError(t, store.ingest(ctx, []*schemav1.InMemoryProfile{&p.p}, p.lbls, p.profileName))
 				for store.flushing.Load() {
 					time.Sleep(time.Millisecond)
 				}
@@ -302,7 +302,7 @@ func TestProfileStore_Ingestion_SeriesIndexes(t *testing.T) {
 
 	for i := 0; i < 9; i++ {
 		p := threeProfileStreams(i)
-		require.NoError(t, store.ingest(ctx, []schemav1.InMemoryProfile{p.p}, p.lbls, p.profileName))
+		require.NoError(t, store.ingest(ctx, []*schemav1.InMemoryProfile{&p.p}, p.lbls, p.profileName))
 	}
 
 	// flush profiles and ensure the correct number of files are created
@@ -345,7 +345,7 @@ func BenchmarkFlush(b *testing.B) {
 			for i := 0; i < 10^6; i++ {
 				p := threeProfileStreams(i)
 				p.p.Samples = samples
-				require.NoError(b, store.ingest(ctx, []schemav1.InMemoryProfile{p.p}, p.lbls, p.profileName))
+				require.NoError(b, store.ingest(ctx, []*schemav1.InMemoryProfile{&p.p}, p.lbls, p.profileName))
 			}
 			require.NoError(b, store.cutRowGroup(len(store.slice)))
 		}
@@ -602,7 +602,7 @@ func TestRemoveFailedSegment(t *testing.T) {
 	require.NoError(t, store.Init(dir, defaultParquetConfig, contextHeadMetrics(context.Background())))
 	// fake a failed segment
 	_, err := os.Create(dir + "/profiles.0.parquet")
-	require.NoError(t, store.ingest(context.Background(), []schemav1.InMemoryProfile{{}}, phlaremodel.LabelsFromStrings(), "memory"))
+	require.NoError(t, store.ingest(context.Background(), []*schemav1.InMemoryProfile{{}}, phlaremodel.LabelsFromStrings(), "memory"))
 	require.NoError(t, err)
 	err = store.cutRowGroup(1)
 	require.NoError(t, err)

diff --git a/pkg/phlaredb/symdb/dedup_slice.go b/pkg/phlaredb/symdb/dedup_slice.go
@@ -29,7 +29,7 @@ var (
 //   - PartitionWriter should only rewrite profile symbol indices;
 //   - InMemoryProfile should be created somewhere else on the call side.
 
-func (p *PartitionWriter) WriteProfileSymbols(profile *profilev1.Profile) []schemav1.InMemoryProfile {
+func (p *PartitionWriter) WriteProfileSymbols(profile *profilev1.Profile) []*schemav1.InMemoryProfile {
 	// create a rewriter state
 	rewrites := &rewriter{}
 
@@ -87,9 +87,9 @@ func (p *PartitionWriter) WriteProfileSymbols(profile *profilev1.Profile) []sche
 	p.locations.ingest(locs, rewrites)
 	samplesPerType := p.convertSamples(rewrites, profile.Sample, spans)
 
-	profiles := make([]schemav1.InMemoryProfile, len(samplesPerType))
+	profiles := make([]*schemav1.InMemoryProfile, len(samplesPerType))
 	for idxType := range samplesPerType {
-		profiles[idxType] = schemav1.InMemoryProfile{
+		profiles[idxType] = &schemav1.InMemoryProfile{
 			StacktracePartition: p.header.Partition,
 			Samples:             samplesPerType[idxType],
 			DropFrames:          profile.DropFrames,

diff --git a/pkg/phlaredb/symdb/symdb.go b/pkg/phlaredb/symdb/symdb.go
@@ -175,7 +175,7 @@ func (s *SymDB) newPartition(partition uint64) *PartitionWriter {
 	return &p
 }
 
-func (s *SymDB) WriteProfileSymbols(partition uint64, profile *profilev1.Profile) []schemav1.InMemoryProfile {
+func (s *SymDB) WriteProfileSymbols(partition uint64, profile *profilev1.Profile) []*schemav1.InMemoryProfile {
 	return s.PartitionWriter(partition).WriteProfileSymbols(profile)
 }