Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Fit mode styles #1374

Closed
wants to merge 4 commits into from

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Aug 9, 2022

  • Fixed FitMode select height in web app
    image

  • Removed webapp/javascript/components/ProfilerHeader.module.css as unused

before:
image
after:
image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 410.09 KB (0%) 8.3 s (0%) 4.3 s (+6.83% 🔺) 12.5 s
webapp/public/assets/app.css 14.03 KB (+0.14% 🔺) 281 ms (+0.14% 🔺) 0 ms (+100% 🔺) 281 ms
webapp/public/assets/styles.css 9.82 KB (+0.04% 🔺) 197 ms (+0.04% 🔺) 0 ms (+100% 🔺) 197 ms
packages/pyroscope-flamegraph/dist/index.js 90.13 KB (0%) 1.9 s (0%) 2.1 s (+27.34% 🔺) 3.9 s
packages/pyroscope-flamegraph/dist/index.node.js 81.46 KB (0%) 1.7 s (0%) 568 ms (-2.1% 🔽) 2.2 s
packages/pyroscope-flamegraph/dist/index.css 5.85 KB (+0.29% 🔺) 118 ms (+0.29% 🔺) 0 ms (+100% 🔺) 118 ms

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1374 (f29e4a7) into main (eab8ef9) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1374   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files         123      123           
  Lines        4040     4040           
  Branches      930      930           
=======================================
  Hits         2729     2729           
  Misses       1307     1307           
  Partials        4        4           
Impacted Files Coverage Δ
...pyroscope-flamegraph/src/ProfilerHeader.module.css 61.54% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eh-am
Copy link
Collaborator

eh-am commented Aug 12, 2022

Should be superseeded by #1388

@eh-am eh-am closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants