Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(panel-plugin): allow setting different views #1712

Merged
merged 7 commits into from Nov 14, 2022
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Nov 14, 2022

image
Screen Shot 2022-11-14 at 15 14 27

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 490.52 KB (+0.02% 🔺) 9.9 s (+0.02% 🔺) 4 s (+6.48% 🔺) 13.8 s
webapp/public/assets/app.css 19.33 KB (0%) 387 ms (0%) 0 ms (+100% 🔺) 387 ms
webapp/public/assets/styles.css 9.54 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 131.87 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 1.8 s (+15.12% 🔺) 4.4 s
packages/pyroscope-flamegraph/dist/index.node.js 132.5 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 853 ms (+34.29% 🔺) 3.6 s
packages/pyroscope-flamegraph/dist/index.css 8.33 KB (0%) 167 ms (0%) 0 ms (+100% 🔺) 167 ms

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 66.26% // Head: 66.25% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a205f8e) compared to base (3c6989f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
- Coverage   66.26%   66.25%   -0.00%     
==========================================
  Files         165      165              
  Lines        5464     5466       +2     
  Branches     1224     1225       +1     
==========================================
+ Hits         3620     3621       +1     
- Misses       1837     1838       +1     
  Partials        7        7              
Impacted Files Coverage Δ
...e-flamegraph/src/FlameGraph/FlameGraphRenderer.tsx 50.00% <ø> (+0.60%) ⬆️
...graph/src/FlameGraph/FlameGraphComponent/index.tsx 80.54% <100.00%> (-1.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am eh-am marked this pull request as ready for review November 14, 2022 15:26
@Rperry2174 Rperry2174 self-requested a review November 14, 2022 15:41
@eh-am eh-am merged commit 058099c into main Nov 14, 2022
@eh-am eh-am deleted the feat/panel-display-only branch November 14, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants