Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repace word-wrap with secure variant #2006

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: repace word-wrap with secure variant #2006

merged 1 commit into from
Jul 18, 2023

Conversation

darrenjaneczek
Copy link
Collaborator

  • Force version of: 
    "optionator": "^0.9.3",
    to ensure import of an alternative implementation of word-wrap, which doesn't trigger security concerns.

@darrenjaneczek darrenjaneczek mentioned this pull request Jul 17, 2023
Closed
@github-actions
Copy link
Contributor

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 998.48 KB (0%) 20 s (0%) 3.7 s (-18.28% 🔽) 23.6 s
webapp/public/assets/app.css 19.9 KB (0%) 399 ms (0%) 0 ms (+100% 🔺) 399 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 625.75 KB (0%) 12.6 s (0%) 2.1 s (+5.19% 🔺) 14.6 s
packages/pyroscope-flamegraph/dist/index.node.js 626.45 KB (0%) 12.6 s (0%) 829 ms (+27.31% 🔺) 13.4 s
packages/pyroscope-flamegraph/dist/index.css 8.14 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@github-actions
Copy link
Contributor

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@darrenjaneczek darrenjaneczek marked this pull request as ready for review July 17, 2023 20:04
Rperry2174
Rperry2174 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@darrenjaneczek darrenjaneczek merged commit 57405c8 into main Jul 18, 2023
21 checks passed
@darrenjaneczek darrenjaneczek deleted the chore/dependency-fix-wordwrap branch July 18, 2023 13:12
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jul 20, 2023
@darrenjaneczek @simonswine
fix: repace word-wrap with secure variant (grafana#2006)
9ced62c
simonswine pushed a commit that referenced this pull request Jul 20, 2023
@darrenjaneczek @simonswine
fix: repace word-wrap with secure variant (#2006)
b811f89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rperry2174 Rperry2174 Rperry2174 approved these changes

@abannachGrafana abannachGrafana abannachGrafana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darrenjaneczek @Rperry2174 @abannachGrafana