Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit time picker presets #2008

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: limit time picker presets #2008

merged 1 commit into from
Jul 20, 2023

Conversation

darrenjaneczek
Copy link
Collaborator

@darrenjaneczek darrenjaneczek commented Jul 17, 2023

The new maximum time range preset if 90 days.

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #2008 (7f9c913) into main (f438451) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files         177      177           
  Lines        4999     4999           
  Branches     1158     1158           
=======================================
  Hits         3021     3021           
  Misses       1966     1966           
  Partials       12       12           

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 998.79 KB (-0.01% 🔽) 20 s (-0.01% 🔽) 4.8 s (-13.06% 🔽) 24.7 s
webapp/public/assets/app.css 19.9 KB (0%) 399 ms (0%) 0 ms (+100% 🔺) 399 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 625.81 KB (0%) 12.6 s (0%) 1.9 s (-16.03% 🔽) 14.4 s
packages/pyroscope-flamegraph/dist/index.node.js 626.56 KB (0%) 12.6 s (0%) 1.2 s (+52.72% 🔺) 13.7 s
packages/pyroscope-flamegraph/dist/index.css 8.14 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@Rperry2174
Copy link
Contributor

Rperry2174 commented Jul 18, 2023

@cyriltovena whats the longest preset we should support here? I would say lets go one more and make the max preset 30 days

@darrenjaneczek darrenjaneczek marked this pull request as ready for review July 20, 2023 13:48
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with leaving the 90 days for now

LGTM

@simonswine simonswine merged commit 56ec1d1 into main Jul 20, 2023
22 checks passed
@simonswine simonswine deleted the fix/time-picker-presets branch July 20, 2023 13:58
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jul 20, 2023
simonswine pushed a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants