Update datasources.yml #2161
Merged
Update datasources.yml #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
simonswine
approved these changes
Jul 24, 2023
|
Let me double check before merging. I think the reason we use a custom data source here has something to do with being able to view exemplars (traces + profiles linked together) |
|
Yeah it turns out this was so that we could do profiling exmplars and show them in grafana: relevant links: But looks like the datasource doesn't work anymore anyway so I think this is fine |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 26, 2023
Rperry2174
pushed a commit
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.