-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive series from pprof sample labels #2387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kolesnikovae
force-pushed
the
chore/preserve-sample-labels
branch
from
September 12, 2023 14:04
9c3fce1
to
22565e1
Compare
kolesnikovae
changed the title
Preserve sample labels at normalisation
WIP: Derive series from pprof sample labels
Sep 12, 2023
kolesnikovae
force-pushed
the
chore/preserve-sample-labels
branch
from
September 21, 2023 09:26
67a9b27
to
b9c2779
Compare
kolesnikovae
force-pushed
the
chore/preserve-sample-labels
branch
from
September 21, 2023 09:58
b9c2779
to
92cf873
Compare
kolesnikovae
changed the title
WIP: Derive series from pprof sample labels
Derive series from pprof sample labels
Sep 21, 2023
nit: maybe add go.cpu.labels.pprof to pkg/test/integration/ingest_pprof_test.go |
Should also fix #2429 |
Although it is not used, we will need it soon (see #2396 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, distributor does not preserve sample labels at normalisation. For example, samples
cut to:
With this change, labeled pprof samples are exported as indpendent series. Thus, if a profile with external label set
contains samples labeled with
span_name="A"
andspan_name="B"
, distributor will extract them and send to ingesters in accordance to the newly created series labels:In practice this allows for more granular queries. For example, profile of an HTTP/gRPC endpoint:
Screen.Recording.2023-09-21.at.18.10.25.mov