Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a way to validate local blocks #2397

Merged
merged 3 commits into from Sep 13, 2023
Merged

Adds a way to validate local blocks #2397

merged 3 commits into from Sep 13, 2023

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Sep 12, 2023

This will allow us to ensure blocks downloaded locally are valid before uploading or compacting.

For now I'm using file system bucket storage for simplicity but it might be more efficient in the future to just use the filesystem.

@cyriltovena cyriltovena requested a review from a team as a code owner September 12, 2023 14:41
@cyriltovena cyriltovena enabled auto-merge (squash) September 12, 2023 16:39
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LE(ven)B(etter)TM

@cyriltovena cyriltovena merged commit d07d228 into main Sep 13, 2023
15 checks passed
@cyriltovena cyriltovena deleted the feat/validateblock2 branch September 13, 2023 13:44
@cyriltovena cyriltovena mentioned this pull request Sep 29, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants