Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix 2 races #2402

Merged
merged 24 commits into from Sep 14, 2023
Merged

fix: fix 2 races #2402

merged 24 commits into from Sep 14, 2023

Conversation

korniltsev
Copy link
Collaborator

  • add integration tests, which do {ingest,push} then {render,SelectMergeProfile}
  • fix two races

@korniltsev korniltsev requested a review from a team as a code owner September 14, 2023 12:00
cyriltovena
cyriltovena approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev
Copy link
Collaborator Author

I hope the tests will not be flaky 🤞🏼

@korniltsev korniltsev merged commit 4e35dff into main Sep 14, 2023
15 checks passed
@korniltsev korniltsev deleted the integration_tests branch September 14, 2023 12:46
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korniltsev @cyriltovena