api: Improve http errors #2408
Merged
api: Improve http errors #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Sep 14, 2023
| @@ -20,11 +19,11 @@ func (f *Frontend) SelectMergeProfile(ctx context.Context, c *connect.Request[qu | |||
| ctx = connectgrpc.WithProcedure(ctx, querierv1connect.QuerierServiceSelectMergeProfileProcedure) | |||
| tenantIDs, err := tenant.TenantIDs(ctx) | |||
| if err != nil { | |||
| return nil, connect.NewError(http.StatusBadRequest, err) | |||
| return nil, connect.NewError(connect.CodeInvalidArgument, err) | |||
There was a problem hiding this comment.
This is what paged me today.
simonswine
reviewed
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, I only wanted to fix some wrong connect error translation but then I realized we have many different ways of doing HTTP errors.
This PR makes sure we use the same function
util.WriteErrororutil.WriteErrorWithStatuswhich generates the same HTTP JSON response as the connect API.Fixes #2368