Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributors list #2453

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Update contributors list #2453

merged 2 commits into from
Sep 26, 2023

Conversation

Rperry2174
Copy link
Contributor

Add darren! :)

@Rperry2174 Rperry2174 requested a review from a team as a code owner September 25, 2023 18:06
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@simonswine
Copy link
Contributor

#2454 should fix the helm problem going forward

@petethepig probably worth bringing the update-contributors workflow back just tried that quickly and am stuck with this:

❯ yarn contributor-faces
yarn run v1.22.19
$ /Users/christian/git/github.com/grafana/pyroscope/node_modules/.bin/contributor-faces
/Users/christian/git/github.com/grafana/pyroscope/node_modules/contributor-faces/node_modules/meow/index.js:8
var trimNewlines = require('trim-newlines');
                   ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/christian/git/github.com/grafana/pyroscope/node_modules/trim-newlines/index.js from /Users/christian/git/github.com/grafana/pyroscope/node_modules/contributor-faces/node_modules/meow/index.js not supported.
Instead change the require of /Users/christian/git/github.com/grafana/pyroscope/node_modules/trim-newlines/index.js in /Users/christian/git/github.com/grafana/pyroscope/node_modules/contributor-faces/node_modules/meow/index.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/Users/christian/git/github.com/grafana/pyroscope/node_modules/contributor-faces/node_modules/meow/index.js:8:20)
    at Object.<anonymous> (/Users/christian/git/github.com/grafana/pyroscope/node_modules/contributor-faces/cli.js:4:14) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v18.17.1

@Rperry2174 Rperry2174 merged commit 08cc3a8 into main Sep 26, 2023
16 checks passed
@Rperry2174 Rperry2174 deleted the Rperry2174-patch-1 branch September 26, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants