Add script to test packaging artifacts #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20230928_add-package-test-script
branch
from
c27b6a5
to
da7b666
Compare
This also fixes a start-up problem for the pyroscope service in both deb and rpm.
simonswine
force-pushed
the
20230928_add-package-test-script
branch
from
da7b666
to
0e215f9
Compare
cyriltovena
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Following @wilfriedroset LGTM I have no idea what's going on :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to validate RPM/DEB pacakges.
I noticed a problem with the systemd unit after install: Basically the data directory was not created and also not specified correctly.
With this it will use
/var/lib/pyroscopeand create it as part of the./postinstallcc @wilfriedroset