Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a race detected when generating ULID #2467

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

cyriltovena
Copy link
Contributor

Stumble on this while working on compactor.

the entropy must be thread safe and the crypto/rand is.

@cyriltovena cyriltovena requested a review from a team as a code owner September 29, 2023 12:43
@cyriltovena cyriltovena mentioned this pull request Sep 29, 2023
7 tasks
@cyriltovena cyriltovena enabled auto-merge (squash) September 29, 2023 12:45
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit dfd42aa into main Sep 29, 2023
16 checks passed
@cyriltovena cyriltovena deleted the bugfix/race-ulid branch September 29, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants