Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load stack trace chunks synchronously #2490

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Load stack trace chunks synchronously #2490

merged 2 commits into from
Oct 5, 2023

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Oct 5, 2023 •
edited

The change removes unused wait group.

@kolesnikovae kolesnikovae changed the title Allow for synchronous stack trace resolve Load stack trace chunks synchronously Oct 5, 2023
cyriltovena
cyriltovena approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolesnikovae kolesnikovae marked this pull request as ready for review October 5, 2023 12:15
@kolesnikovae kolesnikovae requested a review from a team as a code owner October 5, 2023 12:15
@kolesnikovae kolesnikovae merged commit 9fda0ce into main Oct 5, 2023
16 checks passed
@kolesnikovae kolesnikovae deleted the synch-stacktrace-resolve branch October 5, 2023 12:15
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kolesnikovae @cyriltovena