-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimized pprof symbolication #2679
Conversation
246dcf3
to
29f71d1
Compare
@kolesnikovae This looks like an interesting feature. Should we add doc for this? |
This is more an performance optimisation so far so not much to document yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change only affects internals with no impact on the end user in terms of the system behaviour and mechanics. This is a preparation step for some of the features we want to implement (for which we will need docs, indeed) |
# Conflicts: # pkg/phlaredb/block_querier.go
The main goal of the change is to make generated pprof proto type the only profile representation we deal with in the backend:
Next steps:
SelectMergeStacktraces
APIDependent issues: