-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ebpf): python arm64 #2703
fix(ebpf): python arm64 #2703
Conversation
oops, the tests says alpine-arm64 is also broken |
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func InitGitSubmodule(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everybody hates to use git submodules so I try to pretend it is not there :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
_gil_runtime_state
is different because of different size ofpthread_mutex_t
I currently fix it, by subtracting mutex difference size. we may need to generate separate offsets in the future. https://github.com/grafana/pyroscope/pull/2703/files#diff-27c90d69894a05a2db8d2b9dea5ba7ef89ff2739f0382932c76f1e3beab72bdcR67 ,