Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ebpf): python arm64 #2703

Merged
merged 30 commits into from
Nov 23, 2023
Merged

fix(ebpf): python arm64 #2703

merged 30 commits into from
Nov 23, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Nov 16, 2023

  • extract dwarfdump to dump multiple things
  • generate offsets for arm64 pythons
  • generate offsets for arm64 && amd64 glibc
  • generate offsets for arm64 && amd64 musl
  • add ci job running arm tests in qemu, the VM image is built manually and uploaded to pyroscope dockerhub
  • there is one extra difference noticed between python-musl-arm64 and python-glibc-arm64 the size of _gil_runtime_state is different because of different size of pthread_mutex_t I currently fix it, by subtracting mutex difference size. we may need to generate separate offsets in the future. https://github.com/grafana/pyroscope/pull/2703/files#diff-27c90d69894a05a2db8d2b9dea5ba7ef89ff2739f0382932c76f1e3beab72bdcR67 ,

@korniltsev
Copy link
Collaborator Author

oops, the tests says alpine-arm64 is also broken

@korniltsev korniltsev marked this pull request as ready for review November 21, 2023 12:14
@korniltsev korniltsev requested a review from a team as a code owner November 21, 2023 12:14
"github.com/stretchr/testify/require"
)

func InitGitSubmodule(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everybody hates to use git submodules so I try to pretend it is not there :D

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit e7f202e into main Nov 23, 2023
19 checks passed
@cyriltovena cyriltovena deleted the ebpf-python-arm64 branch November 23, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants