Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tracing demo #2791

Merged
merged 8 commits into from Dec 5, 2023
Merged

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Dec 1, 2023

Depends on grafana/otel-profiling-go#9

In the updated version the flamegraph is embedded into the span view:
https://github.com/grafana/otel-profiling-go/assets/12090599/31e33cd1-818b-4116-b952-c9ec7b1fb593

@kolesnikovae kolesnikovae marked this pull request as ready for review December 1, 2023 11:24
@kolesnikovae kolesnikovae requested a review from a team as a code owner December 1, 2023 11:24
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolesnikovae kolesnikovae merged commit 370e49f into main Dec 5, 2023
19 checks passed
@kolesnikovae kolesnikovae deleted the chore/update-tracing-demo-1.2 branch December 5, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants