Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backport workflow to cherry-pick PR merge commits to other long-lived branches #2954

Merged

Conversation

jdbaldry
Copy link
Member

Taking a look at the backport Action.

GitHub token with issue, comment, and label read/write permissions

It looks to be covered by the default permissions for GITHUB_TOKEN.

I'm guessing that the Action does require extra permissions since all other instances of the workflow are using PATs or apps but we can test this by merging this PR and trying a backport.

Use of the workflow is documented in Backport changes although the documentation is pretty specific to Grafana, the workflow will behave similarly here.

…ived branches

Taking a look at the [backport Action](https://github.com/grafana/grafana-github-actions/blob/main/backport/action.yml#L5).

> GitHub token with issue, comment, and label read/write permissions

It looks to be covered by the default permissions for [`GITHUB_TOKEN`](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token).

I'm guessing that the Action does require extra permissions since all other instances of the workflow are using PATs or apps but we can test this by merging this PR and trying a backport.

Use of the workflow is documented in [Backport changes](https://grafana.com/docs/writers-toolkit/review/backporting/) although the documentation is pretty specific to Grafana, the workflow will behave similarly here.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested a review from a team as a code owner January 19, 2024 16:44
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Obviously very hard to test without porting something back for real

@simonswine simonswine merged commit 1cdfc1f into grafana:main Jan 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants