Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tenant settings from microservices deploy #2962

Merged
merged 1 commit into from Jan 26, 2024
Merged

Remove tenant settings from microservices deploy #2962

merged 1 commit into from Jan 26, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jan 24, 2024 •
edited

This fixes a problem when deploying using make deploy-microservices:

❯ make deploy-micro-services
[...]
Error: UPGRADE FAILED: error validating "": error validating data: kind not set
make: *** [Makefile:403: deploy-micro-services] Error 1

A bit shameful but it needed a git bisect to find this.

@simonswine simonswine requested a review from a team as a code owner January 24, 2024 09:19
cyriltovena
cyriltovena approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit dc576e7 into grafana:main Jan 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonswine @cyriltovena