Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct field in mappingsKey #2964

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: Use correct field in mappingsKey #2964

merged 1 commit into from
Jan 25, 2024

Conversation

bryanhuhta
Copy link
Contributor

Previously HasLineNumber in mappingsKey used the value of HasFunctions. This appears to not have caused correctness problems, but this PR fixes it anyways to avoid subtle bugs in the future.

@bryanhuhta bryanhuhta self-assigned this Jan 25, 2024
@bryanhuhta bryanhuhta requested a review from a team as a code owner January 25, 2024 02:30
@bryanhuhta bryanhuhta enabled auto-merge (squash) January 25, 2024 02:30
@kolesnikovae
Copy link
Collaborator

Nice catch!

@bryanhuhta bryanhuhta merged commit d2a3e03 into main Jan 25, 2024
19 checks passed
@bryanhuhta bryanhuhta deleted the fix-mapping-key branch January 25, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants