Add span profiles documentation #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
knylander-grafana
added
the
type/docs
kolesnikovae
approved these changes
Feb 5, 2024
|
|
||
| ## Prerequisites | ||
|
|
||
| 1. Profiling: You will need to have your application instrumented with Pyroscopes Go SDK. If you haven't done this yet, please refer to the [Go (push mode)]({{< relref "../configure-client/language-sdks/go_push" >}}) guide. |
There was a problem hiding this comment.
Just a note: strictly speaking, use of SDK is not required as tracing integration also works in pull mode. However, I do support the idea that we tell users to use SDK, if they want to integrate with tracing, because in this way it's just easier to control which Pyroscope labels match trace tags, e.g., using the same service_name, etc
Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Rperry2174
commented
Feb 6, 2024
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Rperry2174
commented
Feb 6, 2024
Rperry2174
commented
Feb 6, 2024
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
knylander-grafana
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where this should go yet and we will need two more copies for java and ruby. For now making sure I have things correct.
related:
#2980