Fixes merge of empty samples in pprof #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Feb 27, 2024
kolesnikovae
pushed a commit
that referenced
this pull request
Feb 29, 2024
(cherry picked from commit aa403a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in https://github.com/grafana/pyroscope/pull/3010/files#diff-1716fbe09b95462c58b96e3abdc3b60585159cad6f026e731598ca62859ea5e5R49
When we insert an empty profile we still would consider the next one as new and rewrite string from the original twice.
This has caused the pprof API to fail recently.
cc @bryanhuhta @grafakus
Sneaky one !